Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with conda install in Dockerfile #409

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Fix issue with conda install in Dockerfile #409

merged 3 commits into from
Oct 11, 2024

Conversation

ShadowFox88
Copy link
Contributor

Fixes issue #408

153957
153957 requested changes Oct 11, 2024
View reviewed changes
Copy link
Member

@153957 153957 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggested fix (I was not aware that was possible in the requirements file).

However, see comment on #408; it is probably better to change the install command in Dockerfile (or use miniforge).

@ShadowFox88
Copy link
Contributor Author

I have implemented the fix of adding --channel conda-forge, but have not changed the install method to miniforge as I feel that that would be out of scope for this PR, and would be better suited to its own PR where it is changed in both the Dockerfile and Makefile to maintain consistency.

@153957 153957 changed the title Fix issues with requirements-conda.txt Fix issue with conda install in Dockerfile Oct 11, 2024
@153957 153957 merged commit d9ef239 into HiSPARC:master Oct 11, 2024
@153957
Copy link
Member

153957 commented Oct 11, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@153957 153957 153957 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShadowFox88 @153957