Skip to content

Commit

Permalink
Deprecate Homebrew/versions, Homebrew/devel-only.
Browse files Browse the repository at this point in the history
Don't use Homebrew/versions in a test and remove them both from the
OFFICIAL_TAPS list (i.e. `brew search`).
  • Loading branch information
MikeMcQuaid committed Jan 3, 2017
1 parent 2eed2ba commit cd1579a
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 9 deletions.
2 changes: 0 additions & 2 deletions Library/Homebrew/official_taps.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
OFFICIAL_TAPS = %w[
apache
completions
devel-only
dupes
emacs
fuse
Expand All @@ -12,7 +11,6 @@
python
science
tex
versions
x11
].freeze

Expand Down
14 changes: 7 additions & 7 deletions Library/Homebrew/test/tap_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def test_tap
end

assert_match "homebrew/foo", cmd("tap")
assert_match "homebrew/versions", cmd("tap", "--list-official")
assert_match "homebrew/science", cmd("tap", "--list-official")
assert_match "2 taps", cmd("tap-info")
assert_match "https://github.com/Homebrew/homebrew-foo", cmd("tap-info", "homebrew/foo")
assert_match "https://github.com/Homebrew/homebrew-foo", cmd("tap-info", "--json=v1", "--installed")
Expand Down Expand Up @@ -162,17 +162,17 @@ def test_remote
assert_raises(TapUnavailableError) { Tap.new("Homebrew", "bar").remote }
refute_predicate @tap, :custom_remote?

version_tap = Tap.new("Homebrew", "versions")
version_tap.path.mkpath
version_tap.path.cd do
services_tap = Tap.new("Homebrew", "services")
services_tap.path.mkpath
services_tap.path.cd do
shutup do
system "git", "init"
system "git", "remote", "add", "origin", "https://github.com/Homebrew/homebrew-versions"
system "git", "remote", "add", "origin", "https://github.com/Homebrew/homebrew-services"
end
end
refute_predicate version_tap, :private?
refute_predicate services_tap, :private?
ensure
version_tap.path.rmtree if version_tap
services_tap.path.rmtree if services_tap
end

def test_remote_not_git_repo
Expand Down

0 comments on commit cd1579a

Please sign in to comment.