Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-bot fails in github action for custom tap with error "installing formula from paths or URLs is deprecated" #18433

Closed
3 tasks done
swlynch99 opened this issue Sep 27, 2024 · 0 comments · Fixed by #18436
Closed
3 tasks done
Labels
bug Reproducible Homebrew/brew bug

Comments

@swlynch99
Copy link

swlynch99 commented Sep 27, 2024

brew doctor output

(from https://github.com/swlynch99/homebrew-repro-tap/actions/runs/11062989014/job/30738375805?pr=1)

All steps passed!

Verification

  • My "brew doctor output" above says Your system is ready to brew. and am still able to reproduce my issue.
  • I ran brew update twice and am still able to reproduce my issue.
  • This issue's title and/or description do not reference a single formula e.g. brew install wget. If they do, open an issue at https://github.com/Homebrew/homebrew-core/issues/new/choose instead.

brew config output

(from https://github.com/swlynch99/homebrew-repro-tap/actions/runs/11062989014/job/30738375805?pr=1)

HOMEBREW_VERSION: 4.3.24-89-gb72544e
ORIGIN: https://github.com/Homebrew/brew
HEAD: b72544eb04da79e65450ae18ead849d6ff90887f
Last commit: 6 hours ago
Core tap JSON: 27 Sep 01:35 UTC
HOMEBREW_PREFIX: /home/linuxbrew/.linuxbrew
HOMEBREW_BOOTSNAP: set
HOMEBREW_CACHE: /home/runner/.cache/Homebrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_CLEANUP_PERIODIC_FULL_DAYS: 3650
HOMEBREW_COLOR: set
HOMEBREW_CURL_PATH: /usr/bin/curl
HOMEBREW_DEVELOPER: set
HOMEBREW_FAIL_LOG_LINES: 150
HOMEBREW_GITHUB_API_TOKEN: set
HOMEBREW_GIT_EMAIL: [email protected]
HOMEBREW_GIT_NAME: BrewTestBot
HOMEBREW_GIT_PATH: /usr/bin/git
HOMEBREW_LOGS: /home/runner/work/homebrew-repro-tap/homebrew-repro-tap/logs
HOMEBREW_MAKE_JOBS: 4
HOMEBREW_NO_AUTO_UPDATE: set
HOMEBREW_NO_EMOJI: set
HOMEBREW_NO_ENV_HINTS: set
HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK: set
HOMEBREW_SORBET_RUNTIME: set
HOMEBREW_VERIFY_ATTESTATIONS: set
Homebrew Ruby: 3.3.4 => /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/3.3.4_1/bin/ruby
CPU: quad-core 64-bit zen3
Clang: 14.0.0
Git: 2.46.1 => /usr/bin/git
Curl: 7.81.0 => /usr/bin/curl
Kernel: Linux 6.8.0-1014-azure x86_64 GNU/Linux
OS: Ubuntu 22.04.5 LTS (jammy)
Host glibc: 2.35
/usr/bin/gcc: 11.4.0
/usr/bin/ruby: 3.0.2
glibc: N/A
gcc@11: N/A
gcc: N/A
xorg: N/A

What were you trying to do (and why)?

I was attempting to update a formula within a custom tap for one of my company's projects. Previous formula updates using the same github actions workflows had worked fine.

I have since reproduced the issue in a completely empty tap created via brew tap-new (see swlynch99/homebrew-repro-tap#1).

Running brew test-bot locally works fine (other than warning about not being on the default branch) but will always fail in CI.

What happened (include all command output)?

I created a PR with a new formula. In its CI, brew test-bot --only-tap-syntax fails with the following output

==> Using Homebrew/homebrew-test-bot c43db6c (Merge pull request #1237 from Homebrew/dependabot/bundler/sorbet-runtime-0.5.11582)
==> Using Homebrew/brew 4.3.24-89-gb72544eb04 (Merge pull request #18429 from Homebrew/dependabot/github_actions/ruby/setup-ruby-1.194.0)
==> Testing swlynch99/homebrew-repro-tap ca7cf6d (Merge a1cda5305e61ec2e09a3a277171414957db34457 into d110b2b1d35bcbc960bded358822ae3e3a4ebaa3):

==> Running TapSyntax#run!
==> brew style swlynch99/repro-tap
==> brew readall --aliases --os=all --arch=all swlynch99/repro-tap
==> brew audit --except=installed --tap=swlynch99/repro-tap
==> FAILED
Full audit --except=installed --tap=swlynch99/repro-tap output
  Error: Calling installing formulae from paths or URLs is deprecated! Use installing formulae from taps instead.
  Error: Calling installing formulae from paths or URLs is deprecated! Use installing formulae from taps instead.
  Error: Calling installing formulae from paths or URLs is deprecated! Use installing formulae from taps instead.
Error: 1 failed step!
brew audit --except=installed --tap=swlynch99/repro-tap

What did you expect to happen?

brew test-bot should not exit with an error in this case.

Step-by-step reproduction instructions (by running brew commands)

I have a live repro of this failure in the PR/repo here: swlynch99/homebrew-repro-tap#1

  1. Create a new tap
    brew tap-new swlynch99/homebrew-repro-tap
    
  2. Publish said tap as a git repo (see https://github.com/swlynch99/homebrew-repro-tap)
  3. Create a PR with a new formula (see Add cargo-deduplicate-warnings formula swlynch99/homebrew-repro-tap#1)
  4. brew test-bot --only-tap-syntax will then fail in CI.
@swlynch99 swlynch99 added the bug Reproducible Homebrew/brew bug label Sep 27, 2024
@swlynch99 swlynch99 changed the title test-bot fails in github action for custom formula with error "installing formula from paths or URLs is deprecated" test-bot fails in github action for custom tap with error "installing formula from paths or URLs is deprecated" Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Reproducible Homebrew/brew bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant