Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/utils/github_spec: fix artifact URL test #15619

Merged
merged 1 commit into from
Jul 3, 2023
Merged

test/utils/github_spec: fix artifact URL test #15619

merged 1 commit into from
Jul 3, 2023

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Jul 3, 2023 •
edited
Loading

GitHub completely wipes the existance of old CI runs after a couple years.

This'll probably break again in a couple years. Maybe should mock the response or something

@Bo98 Bo98 added the critical Critical change which should be shipped as soon as possible. label Jul 3, 2023
@Bo98 Bo98 merged commit f40b0f9 into Homebrew:master Jul 3, 2023
@Bo98 Bo98 deleted the artifact-test-fix branch July 3, 2023 03:16
@MikeMcQuaid
Copy link
Member

Thanks @Bo98!

@github-actions github-actions bot added the outdated PR was locked due to age label Aug 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nandahkrishna nandahkrishna nandahkrishna approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Bo98 @MikeMcQuaid @BrewTestBot @nandahkrishna