Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Limit usage of GitHub Actions Annotations" #18340

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Sep 16, 2024

Sorry @carlocab, just reverting this for now so it doesn't make it into the next stable release.

I want to keep these errors around for users but avoid doing the opoo calls when it doesn't make sense to do so.

Reverts #18329

Library/Homebrew/extend/kernel.rb Show resolved Hide resolved
Library/Homebrew/extend/kernel.rb Show resolved Hide resolved
Library/Homebrew/utils/github/actions.rb Show resolved Hide resolved
@carlocab
Copy link
Member

carlocab commented Sep 16, 2024

Would be nice to have an opt out for these with something like HOMEBREW_NO_GITHUB_ANNOTATIONS too.

@MikeMcQuaid
Copy link
Member Author

@carlocab Agreed with your suggestions, thanks for that.

Would be nice to have an opt out for these with something like HOMEBREW_NO_GITHUB_ANNOTATIONS too.

Disagree for now, I'd rather we improved these warnings instead.

Library/Homebrew/extend/kernel.rb Outdated Show resolved Hide resolved
Library/Homebrew/extend/kernel.rb Outdated Show resolved Hide resolved
@MikeMcQuaid MikeMcQuaid merged commit 08e5122 into master Sep 16, 2024
51 checks passed
@MikeMcQuaid MikeMcQuaid deleted the revert-18329-limit-annotations branch September 16, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants