Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keg: Install gziped info files during linking #18372

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

ywwry66
Copy link
Contributor

@ywwry66 ywwry66 commented Sep 22, 2024

Currently, brew link installs *.info files to #{HOMEBREW_PREFIX}/share/info/dir using the install_info method. However, some formulae (e.g., Emacs) also ship *.info.gz files, which are only symlinked but not installed.

This PR allows *.info.gz files to be installed during linking in addition to the *.info files.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Currently, `brew link` installs `*.info` files to
`#{HOMEBREW_PREFIX}/share/info/dir` using the `install_info` method.
However, some formulae (e.g., `Emacs`) also ship `*.info.gz` files,
which are only `symlink`ed but not installed.

This commit allows `*.info.gz` files to be installed during linking in
addition to the `*.info` files.
@MikeMcQuaid
Copy link
Member

Thanks again @ywwry66!

@MikeMcQuaid MikeMcQuaid merged commit bd3c7f8 into Homebrew:master Sep 23, 2024
27 checks passed
@ywwry66 ywwry66 deleted the brew-link-install-info-gz branch September 23, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants