CurlDownloadStrategy#_fetch: do not alter variable @url #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of download failure and retry, altering `@url` can cause side effect like repeatedly applying `HOMEBREW_ARTIFACT_DOMAIN`.
|
👍 |
| if ENV["HOMEBREW_ARTIFACT_DOMAIN"] | ||
| @url.sub!(%r{^((ht|f)tps?://)?}, ENV["HOMEBREW_ARTIFACT_DOMAIN"].chomp("/") + "/") | ||
| ohai "Downloading from #{@url}" | ||
| url.sub!(%r{^((ht|f)tps?://)?}, ENV["HOMEBREW_ARTIFACT_DOMAIN"].chomp("/") + "/") |
There was a problem hiding this comment.
Isn't this still indirectly modifying @url as url is referencing the same String instance? If so, this should be fixable by doing url = @url.dup or (probably better) by using String#sub here.
souvik1997
pushed a commit
to souvik1997/brew
that referenced
this pull request
Jul 25, 2016
In case of download failure and retry, altering `@url` can cause side effect like repeatedly applying `HOMEBREW_ARTIFACT_DOMAIN`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of download failure and retry, altering
@urlcan cause sideeffect like repeatedly applying HOMEBREW_ARTIFACT_DOMAIN.