Skip to content
This repository has been archived by the owner on May 16, 2024. It is now read-only.

Update font-arimo-nerd-font from 2.1.0 to 2.2.1 #6167

Merged
merged 2 commits into from
Aug 27, 2022

Conversation

chiefmikey
Copy link
Contributor

Created with brew bump-cask-pr.

@BrewTestBot BrewTestBot added the bump-cask-pr PR was created using `brew bump-cask-pr` label Aug 27, 2022
@bevanjkay
Copy link
Member

@chiefmikey

Error: Version '2.2.1' was automatically detected by livecheck; the appcast should be removed.

@bevanjkay bevanjkay added the awaiting user reply Issue needs response from a user. label Aug 27, 2022
@Finii
Copy link
Contributor

Finii commented Aug 27, 2022

A question maybe for @bevanjkay related to the/all Nerd Fonts casks:

I do not know what livecheck or appcast is 😬 but at least the first sounds like some automated process.

The Nerd Fonts CI creates cask files for all fonts when a new release is published:

https://github.com/ryanoasis/nerd-fonts/actions/runs/2935498962

image

Apart from the fact that the files are generated 'manually' (i.e. not with the recommended font-casker, but that can be changed), would it help to automatically create a PR with them here? Would that be appropriate? Or shall/can we drop the cask file generation in the Nerd Fonts CI?

I'm not shure what has been planned with the cask files from Nerd Fonts side, looks like an unfinished job; that I found when working on the 2.2.0/2.2.1 release.

Any hints welcome :-) Thank you.

Later:
Just noticed that the casks.zip is empty, due to a typo of mine, but the created contents looks ok, for example:

$ cat ../../casks/font-arimo-nerd-font.rb
cask 'font-arimo-nerd-font' do
  version '2.2.1'
  sha256 '5260211447ff71778c2f38f17bbdec2c480bf75c4f2a95e391f124edfc94f105'

  url "https://github.com/ryanoasis/nerd-fonts/releases/download/v#{version}/Arimo.zip"
  appcast 'https://github.com/ryanoasis/nerd-fonts/releases.atom',
          checkpoint: '1cbb983406a21ec3b8c5eb1baefca757a6e188bb819105121924f3bd3ed03c56'
  name 'Arimo Nerd Font (Arimo)'
  homepage 'https://github.com/ryanoasis/nerd-fonts'

  font 'Arimo Italic Nerd Font Complete.ttf'
  font 'Arimo Bold Nerd Font Complete.ttf'
  font 'Arimo Regular Nerd Font Complete.ttf'
  font 'Arimo Bold Italic Nerd Font Complete.ttf'
end

THIS PR uses this file, which includes 'Mono' and 'non-Mono' variants:


cask "font-arimo-nerd-font" do
  version "2.2.1"
  sha256 "5260211447ff71778c2f38f17bbdec2c480bf75c4f2a95e391f124edfc94f105"

  url "https://github.com/ryanoasis/nerd-fonts/releases/download/v#{version}/Arimo.zip"
  appcast "https://github.com/ryanoasis/nerd-fonts/releases.atom"
  name "Arimo Nerd Font (Arimo)"
  homepage "https://github.com/ryanoasis/nerd-fonts"

  font "Arimo Bold Nerd Font Complete.ttf"
  font "Arimo Bold Italic Nerd Font Complete.ttf"
  font "Arimo Regular Nerd Font Complete.ttf"
  font "Arimo Italic Nerd Font Complete.ttf"
  font "Arimo Bold Nerd Font Complete Mono.ttf"
  font "Arimo Bold Italic Nerd Font Complete Mono.ttf"
  font "Arimo Regular Nerd Font Complete Mono.ttf"
  font "Arimo Italic Nerd Font Complete Mono.ttf"
end

Edit: Add 'Later' paragraph

@bevanjkay
Copy link
Member

@Finii The cask files themselves are generally maintained with the homebrew-cask-* repos themselves, as opposed to an entirely new file being pushed, just the version/sha256 values would be pushed (and in the case of font files, potentially any new fonts that have been added/any that have been removed).

A majority of the fonts in this repo are maintained via a script (which is based on those available on Google Fonts).

In most cases a contributor would run the brew bump-cask-pr <token> --version <version> command to submit a version bump PR (whether from a local terminal or CI).

--

Livecheck is a system that allows a user (or a program) to call brew livecheck <token> to see if the current cask file is representing the latest version upstream, and will return the newer available version when appropriate, allowing a brew bump or brew bump-cask-pr command to be run. In the case of projects hosted on GitHub a livecheck stanza is generally not necessary as the :git livecheck strategy will be detected and used automatically based on the url.

@miccal miccal removed the awaiting user reply Issue needs response from a user. label Aug 27, 2022
@miccal miccal merged commit d3b3e52 into Homebrew:master Aug 27, 2022
Finii added a commit to Finii/nerd-fonts that referenced this pull request Aug 30, 2022
[why]
After discussion with
Homebrew/homebrew-cask-fonts#6167 (comment)
I assume we would never use this in CI.

It can be helpful for new fonts, but even then they suggest using the
tools provided (i.e.`font-casker`):
https://github.com/Homebrew/homebrew-cask-fonts/blob/master/CONTRIBUTING.md#automatic-generation

Signed-off-by: Fini Jastrow <[email protected]>
Finii added a commit to Finii/nerd-fonts that referenced this pull request Aug 30, 2022
[why]
After discussion with
Homebrew/homebrew-cask-fonts#6167 (comment)
I assume we would never use this in CI.

It can be helpful for new fonts, but even then they suggest using the
tools provided (i.e.`font-casker`):
https://github.com/Homebrew/homebrew-cask-fonts/blob/master/CONTRIBUTING.md#automatic-generation

Signed-off-by: Fini Jastrow <[email protected]>
Finii added a commit to Finii/nerd-fonts that referenced this pull request Aug 30, 2022
[why]
After discussion with
Homebrew/homebrew-cask-fonts#6167 (comment)
I assume we would never use this in CI.

It can be helpful for new fonts, but even then they suggest using the
tools provided (i.e.`font-casker`):
https://github.com/Homebrew/homebrew-cask-fonts/blob/master/CONTRIBUTING.md#automatic-generation

Signed-off-by: Fini Jastrow <[email protected]>
Finii added a commit to ryanoasis/nerd-fonts that referenced this pull request Aug 30, 2022
[why]
After discussion with
Homebrew/homebrew-cask-fonts#6167 (comment)
I assume we would never use this in CI.

It can be helpful for new fonts, but even then they suggest using the
tools provided (i.e.`font-casker`):
https://github.com/Homebrew/homebrew-cask-fonts/blob/master/CONTRIBUTING.md#automatic-generation

Signed-off-by: Fini Jastrow <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-cask-pr PR was created using `brew bump-cask-pr`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants