Update cDock.app to 7.3 #11021
Update cDock.app to 7.3 #11021
Conversation
|
|
||
| url "http://downloads.sourceforge.net/project/cdock/cDock/cDock_v#{version}.zip" | ||
| name 'cDock' | ||
| homepage 'http://sourceforge.net/projects/cdock/' | ||
| license :oss | ||
|
|
||
| app 'cDock.app' | ||
| app 'cDock.app' :target => '/Applications/cDock.app' |
There was a problem hiding this comment.
Missing a ,. However, please remove this renaming, as it is not the proper way to handle this issue, and :target isn’t meant to be used in this manner. You’d only be changing the symlink, not the location of the app.
There was a problem hiding this comment.
I see. So fixing the popup on app start can't be fixed from homebrew-cask? And the user will just need to deal with it?
There was a problem hiding this comment.
Not necessarily. I just mean :target isn’t appropriate (and might not even work) and another solution should be pursued.
There was a problem hiding this comment.
Can you give me an example of a solution?
On Mon, May 4, 2015 at 8:48 PM, Vítor Galvão [email protected]
wrote:
In Casks/cdock.rb
#11021 (comment)
:url "http://downloads.sourceforge.net/project/cdock/cDock/cDock_v#{version}.zip"
name 'cDock'
homepage 'http://sourceforge.net/projects/cdock/'
license :oss
- app 'cDock.app'
- app 'cDock.app' :target => '/Applications/cDock.app'
Not necessarily. I just mean :target isn’t appropriate (and might not
even work) and another solution should be pursued.—
Reply to this email directly or view it on GitHub
https://github.com/caskroom/homebrew-cask/pull/11021/files#r29637890.
There was a problem hiding this comment.
We don’t have one, yet, that’s the problem. We had a few casks with similar issues but haven’t found an acceptable solution, yet.
There was a problem hiding this comment.
Alrighty, I'll try taking a look at the source when I get time. Hopefully
Ruby shouldn't be that hard (I have limited knowledge in Ruby). I'll fix
(and try squashing the commits) what you said.
On Mon, May 4, 2015 at 8:51 PM, Vítor Galvão [email protected]
wrote:
In Casks/cdock.rb
#11021 (comment)
:url "http://downloads.sourceforge.net/project/cdock/cDock/cDock_v#{version}.zip"
name 'cDock'
homepage 'http://sourceforge.net/projects/cdock/'
license :oss
- app 'cDock.app'
- app 'cDock.app' :target => '/Applications/cDock.app'
We don’t have one, yet, that’s the problem. We had a few casks with
similar issues but haven’t found an acceptable solution, yet.—
Reply to this email directly or view it on GitHub
https://github.com/caskroom/homebrew-cask/pull/11021/files#r29637988.
There was a problem hiding this comment.
Thank you. Copying would go a long way towards solving this, bit is a big endeavour.
|
@vitorgalvao Fixed the problems and squashed! |
#10570
:target => '/Applications/cDock.app'is used to fix the alert on application start.