Add Cave Story.app (English Translation) v0.0.8

[laeryn]

No description provided.

[vitorgalvao]

Where are you getting this url from?

[laeryn]

My own pre patched version of the game I uploaded to Dropbox. I could use a direct link to the game hosted on the official website, but the game wouldn't be translated to English--it would be in Japanese.

On May 31, 2015, at 6:22 PM, Vítor Galvão [email protected] wrote:

In Casks/cave-story.rb:

@@ -0,0 +1,11 @@
+cask :v1 => 'cave-story' do

• version :latest
• sha256 :no_check

• url 'https://dl.dropboxusercontent.com/u/73366966/Cave%20Story.zip?dl=1'
  Where are you getting this url from?

—
Reply to this email directly or view it on GitHub.

[vitorgalvao]

It’s either that or we can’t accept the cask. Non-official links are not allowed, as users should always be able to trust the source.

[laeryn]

Ok, I will make the necessary changes. Thanks!

[laeryn]

Hold on, I am looking at the website and it appears that there is a pre-patched version of the game listed on the download page. However, it is an older version of the game. Should I provide a link for that one? Or should I provide a link to the newer version that is still in Japanese?

Sorry for all my questions, I am new to contributing on GitHub :)

[vitorgalvao]

The latest japanese version should be here. The official older english version can be submitted to caskroom/versions under the name cave-story-en.

[jawshooah]

Might I suggest an additional name '洞窟物語' here?

[laeryn]

Ok, I have added the official download url as listed on their website, and have changed the name like you have suggested. However, I am still running into problems.

When I run brew cask install cave-story, I get this:

Error: It seems the symlink source is not there: '/opt/homebrew-cask/Caskroom/cave-story/0.0.8/Cave Story.app'

The download link listed on the website links to a .dmg file. Could that be why it is acting funny?

Thanks again for all the help!

[vitorgalvao]

We need the link your’re using, to diagnose the problem. Why not use this one, though?

[laeryn]

Ok, here is the link I am using: http://www.nakiwo.com/attachments/doukutsu0_0_8.dmg

As for the English Translation that you mentioned above, it is not the actual Cave Story application. It is an 'English Patch' application for the game. What you do with it is you take the Japanese version of the game downloaded off of the website and drag and drop it onto the 'Cave Story English Patch' application. The patch application then patches the Japanese version of the app to be English.

Originally, I went through this process of patching the application and then uploaded the batched build to dropbox and used that in the cave-story cask. It is a shame they don't have a pre-patched english version on their site :/

[laeryn]

Thanks for helping me on this

[vitorgalvao]

The link you’re using should be working. could you update the PR, so we can see the full cask as you’re building it?

[laeryn]

Yes, I just pushed my new changes

[vitorgalvao]

To be clear, @jawshooah was saying including this in addition to name 'Cave Story. Both names should be available.

[laeryn]

Ok, I will fix that.

Are there any other mistakes I made? I mean, I guess there has to be if its not installing properly haha

[vitorgalvao]

There is a problem indeed, but it’s not your fault and it’s a bit hard to get there if you’ve never seen it. It’s similar to this one. The final cask, with corrections and niceties, should be:

cask :v1 => 'cave-story' do
  version '0.0.8'
  sha256 '305e9ec85442e79e92c0e4fd2d8e6566c5e0ad8db46b50aad172f3e0c384a479'

  # nakiwo.com is the official download host per the vendor homepage
  url "http://www.nakiwo.com/attachments/doukutsu#{version.gsub('.','_')}.dmg"
  name 'Cave Story'
  name 'Doukutsu'
  name '洞窟物語'
  homepage 'http://www.cavestory.org'
  license :closed

  # Renamed for consistency: app name is different in the Finder and in a shell.
  app 'Doukutsu.app', :target => 'Cave Story.app'
end

After making the changes, please don’t forget to squash your commits.

[laeryn]

Thanks so much!

[laeryn]

Ok I have pushed the changes

Would I still be able to create a cask on caskroom/homebrew-unofficial for the english translation I patched?

[vitorgalvao]

Thank you for your work on this.

Would I still be able to create a cask on caskroom/homebrew-unofficial for the english translation I patched?

Yes.