Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Audio Unit and VST plugin folder artifiacts #15643

Merged
merged 1 commit into from
Dec 16, 2015

Conversation

joshka
Copy link
Contributor

@joshka joshka commented Dec 6, 2015

This is an updated version of the PR for this feature that works properly

@adidalal adidalal added enhancement core Issue with Homebrew itself rather than with a specific cask. labels Dec 7, 2015
@adidalal
Copy link
Contributor

adidalal commented Dec 7, 2015

@jawshooah This looks ready to merge.

cask_language_deltas.md will also need to be updated, but as you said, incrementing the version doesn't do anything at this point, so it's up to you.

@adidalal adidalal added the awaiting maintainer feedback Issue needs response from a maintainer. label Dec 8, 2015
@jawshooah
Copy link
Contributor

Waiting on #15381 (which is in turn waiting on Homebrew/legacy-homebrew#46795) so we don't have to push a new release for this to work.

@adidalal
Copy link
Contributor

adidalal commented Dec 9, 2015

@joshka As the previously blocking PR is now merged, would you mind adding the two stanzas to https://github.com/caskroom/homebrew-cask/blob/master/doc/cask_language_deltas.md (under the All Supported Stanzas (1.0) section)?

That way we can keep this PR self-contained and also go ahead and merge it.

@adidalal adidalal removed the awaiting maintainer feedback Issue needs response from a maintainer. label Dec 9, 2015
@joshka
Copy link
Contributor Author

joshka commented Dec 9, 2015

Sure - will do so a little later tonight

@adidalal
Copy link
Contributor

@jawshooah Do we need cask_language_deltas anymore?

Updating that seems to be the only blocker for this merge, (and I don't mind adding it in if does need to be updated - it's like a two line fix)

@adidalal adidalal self-assigned this Dec 16, 2015
@joshka
Copy link
Contributor Author

joshka commented Dec 16, 2015

I got busy and forgot to get around to this. My biggest hassle was understanding how you're versioning the DSL. Happy for you to update this @adityadalal924

@jawshooah
Copy link
Contributor

@adityadalal924 Please do go ahead and add those lines after merging. We likely don't need cask_language_deltas anymore, but I'd like for it to remain up-to-date until we remove it, along with any code relating to DSL versioning.

@adidalal
Copy link
Contributor

@joshka Will merge and update documentation accordingly. I'll put a message over in #15644 once everything is done so you can update that PR accordingly as well.

adidalal pushed a commit that referenced this pull request Dec 16, 2015
Add Audio Unit and VST plugin folder artifiacts
@adidalal adidalal merged commit 2bf6225 into Homebrew:master Dec 16, 2015
Amorymeltzer added a commit to Amorymeltzer/homebrew-cask that referenced this pull request Dec 20, 2015
…ure of brew-cask

- Old github.com links were invalid
- Old Cellar structure was invalid
- Man page regenerated, including content from Homebrew#15643

Refs Homebrew#15381
@adidalal adidalal removed their assignment Dec 29, 2015
@joshka joshka deleted the feature/add-audio-plugin-folders branch January 9, 2016 19:50
@miccal miccal removed core Issue with Homebrew itself rather than with a specific cask. enhancement labels Dec 23, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants