Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quicklook-csv 1.3: Add version and SHA #3272

Closed
wants to merge 1 commit into from

Conversation

sjackman
Copy link
Member

A QuickLook plugin for CSV files

@rolandwalker
Copy link
Contributor

Hi @sjackman! Thanks for the submission!

This one is already available in the repo as quicklook-csv.rb .

@sjackman
Copy link
Member Author

Whoops. My mistake. This updated pull request adds the version and SHA.

@vitorgalvao
Copy link
Member

Actually, having it as it is is currently preferred, as adding a version would make the cask break when the plugin is updated (among other disadvantages). We’re discussing the merits of each method on #1021, if you’d like to join the conversation.

Thank you for your contribution. However, for now we’re sticking with the “latest” option when available (and appropriate), so I’ll close this.

@sjackman
Copy link
Member Author

No worries, Vitor. I'm new to Cask. One question: with the current formula, will brew cask update && brew cask upgrade automatically upgrade quicklook-csv when the DMG is changed?

@vitorgalvao
Copy link
Member

Those commands do not exist. Updating is managed by a regular brew update, and upgrading is being discussed.

@sjackman sjackman deleted the quick-look-csv branch February 19, 2016 00:04
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants