Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding uninstall to haskell-platform #3368

Merged
merged 1 commit into from
Mar 5, 2014

Conversation

drostron
Copy link
Contributor

@drostron drostron commented Mar 4, 2014

No description provided.

@drostron
Copy link
Contributor Author

drostron commented Mar 4, 2014

I'm wondering about desired uninstall behavior for the case where someone has multiple versions of the Haskell platform installed. Is it an issue if the uninstall stanza results in the removal of all versions as the current PR would do? If so we could rely on the uninstall-hs script included with the Haskell platform to uninstall a specific version. That might be tricky unless there is a way to know which version was installed via cask.

@rolandwalker
Copy link
Contributor

Ah. If I understand correctly, the uninstall-hs script needs arguments, to tell it which version to uninstall. We would have a hard time there.

Calling the version method on a Cask will only tell us what that value is for the very latest Cask definition -- not what the value was at a past point in time when the user ran brew cask install. We are really only just getting started on that sort of book-keeping: #3066.

There's also no provision for the user to pass through any command-line arguments to uninstall.

So it seems like :pkgutil is the way to go for now, but that doesn't mean we are giving up on doing better in the future.

If you think it is common for Haskell users to have multiple versions installed, we can add a caveats warning that explains the current uninstall behavior.

@drostron
Copy link
Contributor Author

drostron commented Mar 5, 2014

I was unable to achieve a complete uninstall with :pkgutil and updated the PR to use uninstall-hs instead.

Removing all installed versions seems reasonable for now until additional metadata is stored and available.

@rolandwalker
Copy link
Contributor

Thanks!

rolandwalker added a commit that referenced this pull request Mar 5, 2014
@rolandwalker rolandwalker merged commit acfd341 into Homebrew:master Mar 5, 2014
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants