new cask for manager of mi-wifi

[y00rb]

mi-wifi is one network router of wireless. it has one batch client management tools. this cask is manager in mac version

[vitorgalvao]

As per the naming reference, the file should be named xmrouter.rb with class Xmrouter.

This does seem like a good candidate for an exception, though, so let’s figure out if it is. Do you know why is the app called XMRouter.app? We can rename apps in homebrew-cask; do you think it’d be appropriate in this case?

[rolandwalker]

I am definitely in favor of following the upstream App name wherever possible.

With Bitcoin-core, there was a weird situation where the application menu read differently than the bundle filename. We renamed using :target to resolve a contradiction and reduce confusion.

[vitorgalvao]

Agreed. Still, in this case, and looking into it a bit more, the app name we actually see in finder is 小米路由器, not XMRouter.app. It’s somewhat similar to DEVONthink Pro Office, in this regard (except in this case there isn’t also a possible conflict).

[rolandwalker]

I tried to investigate the plist file, but could not complete the download.

[vitorgalvao]

Here’s the plist’s text, and here’s a mirror of the dmg (both temporary). It is referred to as “XMRouter”; even the bundle identifier is com.xiaomi.xmrouter.

[rolandwalker]

Downloaded, thanks.

The bundle on disk is called "XMRouter.app", which is what you will see in ls.

The reason it displays differently in Finder is that the English localization strings in XMRouter.app/Contents/Resources/en.lproj/InfoPlist.strings are in Chinese. (You are seeing the value of the CFBundleDisplayName key.) This is not the only app that uses foreign languages specifically in the English locale -- it seems contrary to the purpose of having a locale, but there must be some reason developers do this.

We have a number of Chinese-language apps now, which is a good thing. I wish we had a consistent way of naming them, but we currently don't.

[y00rb]

XM is short name Xiao mi(小米)， router is application to manage wireless router.

[y00rb]

sorry, busy in these days, will rename it asap.

[y00rb]

so I will rename it to xmrouter.rb.
btw I have use English in my mac too, installs & works in my mac. how was your problem in different language issue?

[rolandwalker]

OK @yangbodotnet, I think xmrouter.rb will be fine.

We didn't have a error here. We were just looking at how Finder represented the name, and continuing a long-running conversation about how we make names consistent.

[y00rb]

@rolandwalker changed :)
looking & learning your conversation too

[vitorgalvao]

Could you please remove this extra line?

[y00rb]

@vitorgalvao thank you very much, your comment help me found other issues, my cask is wrong location. all of them has been fixed.

[vitorgalvao]

Thank you for the contribution and your work on this. Merged.