Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding cask task for go-agent and go-server #5352

Closed
wants to merge 3 commits into from

Conversation

jskswamy
Copy link
Contributor

No description provided.

@vitorgalvao
Copy link
Member

Why the link rename?

@jskswamy
Copy link
Contributor Author

I thought its a good practice to provide a name without space, I can remove it if its unnecessary

@vitorgalvao
Copy link
Member

Apps should retain their original name, except in very specific cases, where there is a very strong reason to rename them (link with a different name, to be more precise). The link stanza should remain, though, like you had previously, only the :target part should be removed.

@jskswamy
Copy link
Contributor Author

Can you merge the commit, let me know if I'm still missing anything.

@vinkla
Copy link
Contributor

vinkla commented Jul 17, 2014

Thank you for the contribution. It can be merged in a different pull request due to some simple recommended alterations. Your contribution is still included (and still credited to you), with the appropriate modifications, when applicable.

Reference: Facilitated future updates.

@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants