Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add IPFS Desktop v0.7.0 #60498

Merged
merged 3 commits into from
Mar 17, 2019
Merged

feat: add IPFS Desktop v0.7.0 #60498

merged 3 commits into from
Mar 17, 2019

Conversation

hacdias
Copy link
Contributor

@hacdias hacdias commented Mar 17, 2019

Hii! I'd like to add IPFS Desktop if possible 😃

I kept the name as ipfs-desktop because it is different from ipfs even though your documentation say to remove it.

Ref.: ipfs/ipfs-desktop#691


After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.
  • The submission is for a stable version or documented exception.

Additionally, if adding a new cask:

@hacdias
Copy link
Contributor Author

hacdias commented Mar 17, 2019

@vitorgalvao I don't know if ipfs-desktop should be called ipfs here. There's already an ipfs package on brew that is not a cask and it might generate some confusion, no?

@vitorgalvao
Copy link
Member

There's already an ipfs package on brew

There are several others in the same situation.

@hacdias
Copy link
Contributor Author

hacdias commented Mar 17, 2019

@vitorgalvao it seems CI is emitting a warning because of that:

https://travis-ci.org/Homebrew/homebrew-cask/builds/507591873#L320

@vitorgalvao
Copy link
Member

it seems CI is emitting a warning because of that

Yes, that’s expected. It should be a warning and not a failure. I’ve verified the rest locally. Thank you for your contribution.

@vitorgalvao vitorgalvao merged commit a902c27 into Homebrew:master Mar 17, 2019
@hacdias hacdias deleted the patch-1 branch March 17, 2019 22:21
@hacdias
Copy link
Contributor Author

hacdias commented Mar 17, 2019

@vitorgalvao thanks! I'll make sure to keep this cask updated 😄

@lock lock bot added the outdated label Apr 16, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants