Upgrade Futuniuniu.app to v2.16.354, and linking with Chinese app name #7435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| url 'http://www.futu5.com/client/nn/mac/FTNNForMac_2.14.316_0904.dmg' | ||
| url "https://www.futu5.com/client/nn/mac/FTNNForMac_2.16.354_1117.dmg" |
There was a problem hiding this comment.
Please don’t change the quote style. Double quotes are reserved for cases of string interpolation (which you may achieve here by changing this line to url "https://www.futu5.com/client/nn/mac/FTNNForMac_#{version}.dmg" and version to 2.16.354_1117).
|
Thanks for reply, I'll change according your feedback. |
|
I've made some changes based on your suggestions, please review again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.