groonga 13.0.1 #126947
Merged
groonga 13.0.1 #126947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrewTestBot
added
the
bump-formula-pr
SMillerDev
approved these changes
Mar 29, 2023
SMillerDev
reviewed
Mar 29, 2023
Formula/groonga.rb
Outdated
| # Temporary workaround for `msgpack` rename. Remove when resolved: | ||
| # https://github.com/groonga/groonga/issues/1536 | ||
| args << "--with-message-pack=#{Formula["msgpack"].opt_prefix}" | ||
|
|
||
| if build.head? | ||
| args << "--with-ruby" |
There was a problem hiding this comment.
Any idea why we're only doing this for head?
There was a problem hiding this comment.
Not really sure. This was added in Homebrew/legacy-homebrew#45792. I don't have enough context to reason. But I think it probably should be applied to stable versions too: https://groonga.org/docs/contribution/development/build/unix_autotools.html
ZhongRuoyu
force-pushed
the
bump-groonga-13.0.1
branch
from
6038e96 to
07437de
Compare
Looks better to drop it |
BrewTestBot
removed
the
ruby
|
Same error. Might be something in |
p-linnane
approved these changes
Mar 29, 2023
|
🤖 A scheduled task has requested bottles to be published to this PR. |
github-actions
bot
added
the
CI-published-bottle-commits
abetomo
added a commit
to abetomo/nroonga
that referenced
this pull request
Apr 20, 2023
When installing Groonga on Mac with Homebrew, Ruby plugin is no longer included. Homebrew/homebrew-core#126947 Signed-off-by: abetomo <[email protected]>
kou
pushed a commit
to nroonga/nroonga
that referenced
this pull request
Apr 20, 2023
When installing Groonga on Mac with Homebrew, Ruby plugin is no longer included. Homebrew/homebrew-core#126947 Signed-off-by: abetomo <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bumpCreated with
brew bump-formula-pr.resourceblocks may require updates.