Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

circleci: support telemetry #137382

Closed
wants to merge 2 commits into from
Closed

circleci: support telemetry #137382

wants to merge 2 commits into from

Conversation

JulesFaucherre
Copy link
Contributor

@JulesFaucherre JulesFaucherre commented Jul 24, 2023 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. go Go use is a significant feature of the PR or issue labels Jul 24, 2023
@SMillerDev
Copy link
Member

Why would we enable it if it's off by default?

@github-actions
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@carlocab carlocab changed the title change circleci formula to support telemetry circleci: support telemetry Jul 24, 2023
@JulesFaucherre JulesFaucherre force-pushed the master branch 2 times, most recently from f183953 to d5a29ab Compare July 24, 2023 07:39
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Jul 24, 2023
@JulesFaucherre
Copy link
Contributor Author

JulesFaucherre commented Jul 24, 2023 •
edited
Loading

This is linked to a pull-request in one of our public repository: CircleCI-Public/circleci-cli#958

@JulesFaucherre
Copy link
Contributor Author

JulesFaucherre commented Jul 24, 2023 •
edited
Loading

@SMillerDev It isn't off by default: the first time you will run the CLI it will ask you if you approve us collecting telemetry with CLI. In the pr, you can see I added the CIRCLECI_CLI_TELEMETRY_OPTOUT=1 on the test commands to make sure the approval prompt does not appear
There is a screenshot in the pr referenced above

@JulesFaucherre JulesFaucherre force-pushed the master branch 2 times, most recently from 340f720 to 8a7e3bd Compare July 24, 2023 13:25
@JulesFaucherre JulesFaucherre mentioned this pull request Jul 24, 2023
Merged
9 tasks
@JulesFaucherre JulesFaucherre force-pushed the master branch 2 times, most recently from 45d0378 to d0a82d0 Compare July 24, 2023 16:48
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Jul 24, 2023
@JulesFaucherre
circleci: change build to support telemetry
8d05a91 
We added telemetry to our CLI. This changes the way it needs to be
build: now it must be given another ldflag. This commit adds the flag.
We also switched our default branch from 'master' to 'main'.
@JulesFaucherre
circleci: Addressed pr comment
b1c0408 
The comment was suggesting moving the declaration of the environment
variable "CIRCLECI_CLI_TELEMETRY_OPTOUT" outside of the command calls
@SMillerDev SMillerDev removed their request for review July 26, 2023 09:10
@JulesFaucherre
Copy link
Contributor Author

To give a bit more context to the PR, the most important part for us is the line

      -X github.com/CircleCI-Public/circleci-cli/telemetry.SegmentEndpoint=https://api.segment.io

The line will allow the binaries built with it to send telemetry events to our telemetry server https://api.segment.io, thus enabling telemetry

SMillerDev
SMillerDev previously approved these changes Aug 1, 2023
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

🤖 An automated task has requested creation of a replacement PR.

@github-actions github-actions bot dismissed SMillerDev’s stale review August 1, 2023 08:03

Replacement PR dispatched

@BrewTestBot BrewTestBot mentioned this pull request Aug 1, 2023
Merged
BrewTestBot pushed a commit that referenced this pull request Aug 1, 2023
@JulesFaucherre @BrewTestBot
circleci: rebuild
d447b3c 
* circleci: change build to support telemetry
  We added telemetry to our CLI. This changes the way it needs to be
  build: now it must be given another ldflag. This commit adds the flag.
  We also switched our default branch from 'master' to 'main'.
* circleci: Addressed pr comment
  The comment was suggesting moving the declaration of the environment
  variable "CIRCLECI_CLI_TELEMETRY_OPTOUT" outside of the command calls

Closes #137382.

Signed-off-by: BrewTestBot <[email protected]>
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Aug 1, 2023
@github-actions github-actions bot added the superseded PR was replaced by another PR label Aug 1, 2023
@BrewTestBot BrewTestBot marked this pull request as draft August 1, 2023 08:03
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

✅ Replacement PR created at #138184.

github-merge-queue bot pushed a commit that referenced this pull request Aug 1, 2023
@BrewTestBot
Merge pull request #138184 from Homebrew/PR/137382
0499886 
Replacement for #137382
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 1, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SMillerDev SMillerDev SMillerDev left review comments

Assignees
No one assigned
Labels
automerge-skip `brew pr-automerge` will skip this pull request autosquash Automatically squash pull request commits according to Homebrew style. go Go use is a significant feature of the PR or issue outdated PR was locked due to age superseded PR was replaced by another PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JulesFaucherre @SMillerDev