go-critic 0.9.0

[stefanb]

https://github.com/go-critic/go-critic/releases/tag/v0.9.0

Compatible with Go 1.21: #134468

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

[github-actions]

🤖 An automated task has requested bottles to be published to this PR.

[chenrui333]

test needs update after go1.21 upgrade

  /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/bin/bundle clean
  ==> Testing go-critic
  ==> /home/linuxbrew/.linuxbrew/Cellar/go-critic/0.9.0/bin/gocritic check main.go 2>&1
  panic: load embedded ruleguard rules: rules/rules.go:13: can't load fmt
  
  goroutine 1 [running]:
  main.main()
  	github.com/go-critic/go-critic/cmd/gocritic/main.go:16 +0x52
  ==> Testing go-critic (again)
  ==> /home/linuxbrew/.linuxbrew/Cellar/go-critic/0.9.0/bin/gocritic check main.go 2>&1
  panic: load embedded ruleguard rules: rules/rules.go:13: can't load fmt
  
  goroutine 1 [running]:
  main.main()
  	github.com/go-critic/go-critic/cmd/gocritic/main.go:16 +0x52
  Error: go-critic: failed
  An exception occurred within a child process:
    Minitest::Assertion: Expected: 1
    Actual: 2

[stefanb]

@chenrui333 could this be fixed just by formula revision bump in #134468, to make sure it is rebuilt with Go 1.21?