Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pigz 2.8 #139968

Merged
merged 2 commits into from
Sep 2, 2023
Merged

pigz 2.8 #139968

merged 2 commits into from
Sep 2, 2023

Conversation

ZhongRuoyu
Copy link
Member

@ZhongRuoyu ZhongRuoyu commented Aug 20, 2023 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@ZhongRuoyu ZhongRuoyu added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Aug 20, 2023
@chenrui333
Copy link
Member

there is a new release 2.8

@ZhongRuoyu ZhongRuoyu changed the title pigz: fix compatibility with zlib 1.3 pigz 2.8 Aug 20, 2023
@chenrui333
Copy link
Member

only failed on arm runners.

@chenrui333 chenrui333 added the test failure CI fails while running the test-do block label Aug 21, 2023
@chenrui333
Copy link
Member

rebased after #139861 merge (build/runs out fine in my ventura arm machine)

@chenrui333 chenrui333 added the CI-requeued PR has been re-added to the queue label Aug 22, 2023
@ZhongRuoyu
Copy link
Member Author

Codesign was invalid, somehow. Anyway, this should work now that we've temporarily disabled relocatable install names in #141081.

@ZhongRuoyu ZhongRuoyu added ready to merge PR can be merged once CI is green and removed CI-requeued PR has been re-added to the queue test failure CI fails while running the test-do block CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Sep 2, 2023
@ZhongRuoyu ZhongRuoyu mentioned this pull request Sep 2, 2023
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Sep 2, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 2, 2023
Merged via the queue into Homebrew:master with commit 4e9d672 Sep 2, 2023
12 checks passed
@ZhongRuoyu ZhongRuoyu deleted the pigz-fix branch September 3, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@iMichka iMichka iMichka approved these changes

Assignees
No one assigned
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZhongRuoyu @chenrui333 @iMichka @BrewTestBot