Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dispatch-build-bottle.yml: account for 14-arm64 #141123

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Conversation

fxcoudert
Copy link
Member

It needs an ephemeral runner.

@fxcoudert fxcoudert requested review from MikeMcQuaid and a team as code owners September 1, 2023 16:14
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request workflows PR modifies GitHub Actions workflow files labels Sep 1, 2023
@Bo98
Copy link
Member

Bo98 commented Sep 1, 2023

12-arm64 is now ephemeral too so let's make this more future proof:

const macOSRegex = /^\d+(?:\.\d+)?(?:-arm64)?$/;
...
  if (macOSRegex.test(s) && s != "11-arm64") // Ephemeral runners

@fxcoudert
Copy link
Member Author

Done

@Bo98 Bo98 added this pull request to the merge queue Sep 1, 2023
Merged via the queue into master with commit fa7b514 Sep 1, 2023
14 checks passed
@Bo98 Bo98 deleted the fxcoudert-patch-1 branch September 1, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request sonoma-bottling workflows PR modifies GitHub Actions workflow files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants