Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tcl-tk: Fix KVO crash #141201

Merged
merged 3 commits into from
Sep 5, 2023
Merged

tcl-tk: Fix KVO crash #141201

merged 3 commits into from
Sep 5, 2023

Conversation

chrstphrchvz
Copy link
Contributor

This crash has been reported several times, particularly by Tkinter users (see e.g. python/cpython#92603); it will be fixed in Tk 8.6.14.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@chrstphrchvz
tcl-tk: Fix KVO crash
768727f 
This crash has been reported several times, particularly by Tkinter users
(see e.g. python/cpython#92603); it will be fixed in Tk 8.6.14.
@chrstphrchvz chrstphrchvz marked this pull request as ready for review September 2, 2023 11:07
@ZhongRuoyu ZhongRuoyu added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Sep 2, 2023
@chrstphrchvz
Copy link
Contributor Author

I have opened https://github.com/orgs/Homebrew/discussions/4761 regarding the occasional CI failure when downloading the itk4 distfile from certain SourceForge mirrors. I noticed the same thing on #130971.

@fxcoudert fxcoudert added the CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. label Sep 4, 2023
ZhongRuoyu
ZhongRuoyu reviewed Sep 4, 2023
View reviewed changes
Formula/t/tcl-tk.rb
patch :p0 do
url "https://raw.githubusercontent.com/macports/macports-ports/6a93695d61d3/x11/tk/files/fix-kvo-crash.diff"
sha256 "ec9a9234b4a326e5621fe78e078c29aa4784b6dc88c59a43d828639ebae0af41"
end
end

resource "itk4" do
Copy link
Member

@ZhongRuoyu ZhongRuoyu Sep 4, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not too sure about this one, but let's see if a mirror helps, like we do for the tk resource:

mirror "https://src.fedoraproject.org/lookaside/extras/itk/itk4.1.0.tar.gz/sha512/1deed09daf66ae1d0cc88550be13814edff650f3ef2ecb5ae8d28daf92e37550b0e46921eb161da8ccc3886aaf62a4a3087df0f13610839b7c2d6f4b39c9f07e/itk4.1.0.tar.gz"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the error encountered for the main URL is fatal and does not lead to retrying with the mirror.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea. But the bottles were built, so it's fine to merge this.

Still, would be nice to figure that out on brew's side, though.

@ZhongRuoyu @chrstphrchvz
tcl-tk: try workaround for itk4 distfile
702f4a3 
`Error: bad URI(is not URI?)` encountered for some SourceForge mirrors
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 4, 2023
ZhongRuoyu
ZhongRuoyu approved these changes Sep 5, 2023
View reviewed changes
Formula/t/tcl-tk.rb
patch :p0 do
url "https://raw.githubusercontent.com/macports/macports-ports/6a93695d61d3/x11/tk/files/fix-kvo-crash.diff"
sha256 "ec9a9234b4a326e5621fe78e078c29aa4784b6dc88c59a43d828639ebae0af41"
end
end

resource "itk4" do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea. But the bottles were built, so it's fine to merge this.

Still, would be nice to figure that out on brew's side, though.

@ZhongRuoyu ZhongRuoyu removed the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 5, 2023
@ZhongRuoyu
Copy link
Member

Thanks for the fix @chrstphrchvz! Merging now.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

:shipit: @ZhongRuoyu has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Sep 5, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 5, 2023
Merged via the queue into Homebrew:master with commit 6952fb4 Sep 5, 2023
@chrstphrchvz chrstphrchvz deleted the patch-1 branch September 5, 2023 02:58
@chrstphrchvz chrstphrchvz mentioned this pull request Sep 5, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fxcoudert fxcoudert fxcoudert approved these changes

@ZhongRuoyu ZhongRuoyu ZhongRuoyu approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrstphrchvz @ZhongRuoyu @fxcoudert @BrewTestBot