Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart-sdk 3.1.1 #141730

Closed
wants to merge 1 commit into from
Closed

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Sep 7, 2023

Created by brew bump


Created with brew bump-formula-pr.

  • resource blocks have been checked for updates.

@github-actions github-actions bot added rust Rust use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Sep 7, 2023
dart-sdk: update resource

Signed-off-by: Rui Chen <[email protected]>
@chenrui333
Copy link
Member Author

[3576/3760] STAMP obj/runtime/bin/standalone_dart_io.stamp
[3577/3760] LINK ./gen_snapshot_product
[3578/3760] STAMP obj/runtime/bin/standalone_dart_io_product.stamp
[3579/3760] LINK ./dart_precompiled_runtime
ld64.lld: warning: cannot export hidden symbol Dart_LoadELF
>>> defined in obj/runtime/bin/elf_loader.elf_loader.o

ld64.lld: warning: cannot export hidden symbol Dart_LoadELF_Memory
>>> defined in obj/runtime/bin/elf_loader.elf_loader.o

ld64.lld: warning: cannot export hidden symbol Dart_UnloadELF
>>> defined in obj/runtime/bin/elf_loader.elf_loader.o
[3580/3760] STAMP obj/runtime_precompiled.stamp
[3581/3760] COPY exe.stripped/gen_snapshot_product dart-sdk/bin/utils/gen_snapshot
[3582/3760] STAMP obj/sdk/copy_gen_snapshot_exe.stamp
[3583/3760] LINK ./gen_snapshot
[3584/3760] COPY gen_snapshot_product.sym dart-sdk/bin/utils/gen_snapshot.sym
[3585/3760] STAMP obj/sdk/copy_gen_snapshot_sym.stamp
[3586/3760] STAMP obj/sdk/copy_gen_snapshot.stamp
[3587/3760] STAMP obj/utils/compiler/dart2js_create_snapshot_entry.stamp
[3588/3760] ACTION //runtime/bin:generate_snapshot_bin(//build/toolchain/mac:clang_arm64)
[3589/3760] STAMP obj/runtime/bin/generate_snapshot_bin.stamp
[3590/3760] LINK ./dart_precompiled_runtime_product
ld64.lld: warning: cannot export hidden symbol Dart_LoadELF
>>> defined in obj/runtime/bin/elf_loader_product.elf_loader.o

ld64.lld: warning: cannot export hidden symbol Dart_LoadELF_Memory
>>> defined in obj/runtime/bin/elf_loader_product.elf_loader.o

ld64.lld: warning: cannot export hidden symbol Dart_UnloadELF

@chenrui333 chenrui333 added build failure CI fails while building the software CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Sep 7, 2023
@chenrui333 chenrui333 added the upstream issue An upstream issue report is needed label Sep 8, 2023
@ntkme
Copy link
Contributor

ntkme commented Sep 8, 2023

It's not upstream issue, instead the formula itself is wrong. See dart-lang/sdk#53464 (comment).

So instead of running:

    system "fetch", "--no-history", "dart"

It should be:

    system "gclient", "config", "--name", "sdk", "https://dart.googlesource.com/sdk.git@#{version}"
    system "gclient", "sync", "--no-history"

Note that with fetch command you cannot specify a git ref to clone, so gclient should be explicitly used to clone the repo with a git ref of the release tag.

@chenrui333
Copy link
Member Author

@ntkme thanks for the pointer, I will look a bit tomorrow. Also if you have bandwidth, feel free to submit a PR :)

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Sep 11, 2023
@chenrui333
Copy link
Member Author

@ntkme can you help on this?

@github-actions github-actions bot removed the stale No recent activity label Sep 12, 2023
@ntkme ntkme mentioned this pull request Sep 12, 2023
@ntkme
Copy link
Contributor

ntkme commented Sep 12, 2023

@chenrui333 PR opened at #142101

@chenrui333
Copy link
Member Author

Thanks @ntkme!

@chenrui333 chenrui333 closed this Sep 12, 2023
@chenrui333 chenrui333 added the superseded PR was replaced by another PR label Sep 12, 2023
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 13, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2023
@chenrui333 chenrui333 deleted the bump-dart-sdk-3.1.1 branch January 22, 2024 17:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build failure CI fails while building the software bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. outdated PR was locked due to age rust Rust use is a significant feature of the PR or issue superseded PR was replaced by another PR upstream issue An upstream issue report is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants