Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish-commit-bottles: increase pagination #147313

Merged
merged 1 commit into from
Sep 29, 2023
Merged

publish-commit-bottles: increase pagination #147313

merged 1 commit into from
Sep 29, 2023

Conversation

p-linnane
Copy link
Member

@p-linnane p-linnane commented Sep 29, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

The GitHub API paginates results, and defaults to 30. For PR's that have over 30 reviews/comments/etc. only the first 30 are being returned. This can cause us to show PR's that are approved as still unapproved. This increases the pagination to return all results.

@p-linnane p-linnane requested review from MikeMcQuaid and a team as code owners September 29, 2023 19:59
@github-actions github-actions bot added workflows PR modifies GitHub Actions workflow files automerge-skip `brew pr-automerge` will skip this pull request labels Sep 29, 2023
Copy link
Member

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📜

@p-linnane p-linnane enabled auto-merge September 29, 2023 20:01
@p-linnane p-linnane added this pull request to the merge queue Sep 29, 2023
@Bo98
Copy link
Member

Bo98 commented Sep 29, 2023

Does passing --paginate work? I think that'll make it 100 and also make sure it continues to work if > 100.

@p-linnane p-linnane removed this pull request from the merge queue due to a manual request Sep 29, 2023
@p-linnane
Copy link
Member Author

Does passing --paginate work? I think that'll make it 100 and also make sure it continues to work if > 100.

Good call. I just tested locally and that worked. I'll push it here.

@p-linnane p-linnane requested a review from Bo98 September 29, 2023 20:07
@p-linnane p-linnane added this pull request to the merge queue Sep 29, 2023
@p-linnane p-linnane mentioned this pull request Sep 29, 2023
6 tasks
Merged via the queue into Homebrew:master with commit df408d6 Sep 29, 2023
14 checks passed
@p-linnane p-linnane deleted the publish-increase-limit branch September 29, 2023 20:12
@p-linnane
Copy link
Member Author

@MikeMcQuaid
Copy link
Member

Nice work @p-linnane!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request workflows PR modifies GitHub Actions workflow files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants