triage: update bump-formula-pr label logic

[chenrui333]

For improving the signal to include more formulae for autobump, Created by brew bump is a better signal than Created by bump-formula-pr for the labeling.

Examples like:

• minio or minio-mc
• luagit

[Bo98]

Bit weird to have a label called bump-formula-pr and to exclude bump-formula-pr.

[Bo98]

Is the motivation behind this about the shorter stale times that brew bump and brew bump-formula-pr currently have?

[chenrui333]

Bit weird to have a label called bump-formula-pr and to exclude bump-formula-pr.

yeah, I can change the label if that helps :)

[chenrui333]

Is the motivation behind this about the shorter stale times that brew bump and brew bump-formula-pr currently have?

not really, the motivation is mostly because brew bump-formula-pr is not a good signal for helping out autobump process (because it can be triggered manually with bunch overrides) I have attached some examples

[MikeMcQuaid]

Bit weird to have a label called bump-formula-pr and to exclude bump-formula-pr.

Agreed. Should have one label that includes both and consider renaming existing label.

[MikeMcQuaid]

Suggested change

	pr_body_content: Created with `brew bump`
	pr_body_content: Created with `brew bump

will cover all cases

[chenrui333]

oh, right now it does cover all cases, it is just the bump-formula-pr can be a false signal when generating autobump list.

[MikeMcQuaid]

it is just the bump-formula-pr can be a false signal when generating autobump list.

sorry, I don't understand what this means: can you elaborate a lot more?

[chenrui333]

Sure, right now, folks can use either bump --open-pr or bump-foruma-pr to create the formula bump PRs, while they both can do the same thing, the bump-formula-pr can take lots of parameters overrides, which would be quite manual rather than something can be done by bot (minio and luagit are examples on this), while AFAIK you can override parameters via bump --open-pr, which means, the PRs using it can be also done by bot.

Let me know if that makes better sense.

[MikeMcQuaid]

I understand the differences between the two approaches but not how that affects what should be labelled what or why the contents of the label affects anything?

[chenrui333]

yeah, i have to say, it seems a bit tricky about getting this perfect 😄

Now, I am gonna manually use cannot-autobump label to help with the autobump signal.

[chenrui333]

Closing this PR for now to use cannot-autobump label to help with autobump process