Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustfmt 1.7.0 #160147

Merged
merged 2 commits into from
Apr 28, 2024
Merged

rustfmt 1.7.0 #160147

merged 2 commits into from
Apr 28, 2024

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Jan 17, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

continuing #152112

@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Jan 17, 2024
@github-actions github-actions bot added the rust Rust use is a significant feature of the PR or issue label Jan 17, 2024
@chenrui333 chenrui333 force-pushed the rustfmt-1.7.0 branch 2 times, most recently from 72de313 to 5e8c756 Compare January 17, 2024 17:17
@chenrui333 chenrui333 added build failure CI fails while building the software linux Linux is specifically affected labels Jan 17, 2024
@chenrui333
Copy link
Member Author

[WARN] entry 4099 in symbol table refers to a non existing section, skipping
Error: An exception occurred within a child process:
  TypeError: no implicit conversion of nil into Integer

@chenrui333 chenrui333 added the help wanted Task(s) needing PRs from the community or maintainers label Jan 17, 2024
@chenrui333 chenrui333 closed this Jan 22, 2024
@chenrui333 chenrui333 deleted the rustfmt-1.7.0 branch January 22, 2024 19:30
@chenrui333 chenrui333 restored the rustfmt-1.7.0 branch February 17, 2024 08:37
@chenrui333
Copy link
Member Author

Give this PR another go after #162122

@chenrui333
Copy link
Member Author

same error with linux build cc @Bo98

@chenrui333
Copy link
Member Author

  [WARN] entry 4099 in symbol table refers to a non existing section, skipping
  Error: An exception occurred within a child process:
    TypeError: no implicit conversion of nil into Integer

@cho-m cho-m added the brew Issue may be Homebrew/brew related label Mar 19, 2024
@Bo98
Copy link
Member

Bo98 commented Mar 19, 2024

The warning part is a Rust bug, librustc_driver contains a bad symbol:

 4099: 0000000000000000 15155 OBJECT  GLOBAL DEFAULT bad section index[ 49] rust_metadata_ru[...]

Given we're using nightly here, bugs are probably expected. Though it doesn't break anything in terms of running things.

Patchelf itself shouldn't crash however. I have a fix for this but might take a few days to get through to a brew release.

@chenrui333
Copy link
Member Author

closing for now, will reopen later.

@chenrui333 chenrui333 closed this Apr 9, 2024
@chenrui333 chenrui333 deleted the rustfmt-1.7.0 branch April 9, 2024 02:56
@chenrui333 chenrui333 restored the rustfmt-1.7.0 branch April 28, 2024 02:54
@chenrui333 chenrui333 reopened this Apr 28, 2024
@chenrui333 chenrui333 removed build failure CI fails while building the software help wanted Task(s) needing PRs from the community or maintainers brew Issue may be Homebrew/brew related linux Linux is specifically affected labels Apr 28, 2024
@chenrui333 chenrui333 added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-requeued PR has been re-added to the queue ready to merge PR can be merged once CI is green and removed CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. blocked CI-requeued PR has been re-added to the queue labels Apr 28, 2024
@chenrui333
Copy link
Member Author

it is good now 🎉 thanks @Bo98!

Signed-off-by: Rui Chen <[email protected]>

autobump: add rustfmt

Signed-off-by: Rui Chen <[email protected]>
@chenrui333 chenrui333 removed the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Apr 28, 2024
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request autobump labels Apr 28, 2024
@chenrui333 chenrui333 removed the automerge-skip `brew pr-automerge` will skip this pull request label Apr 28, 2024
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Apr 28, 2024
@BrewTestBot BrewTestBot enabled auto-merge April 28, 2024 12:38
@BrewTestBot BrewTestBot added this pull request to the merge queue Apr 28, 2024
Merged via the queue into Homebrew:master with commit e765f4c Apr 28, 2024
14 checks passed
@chenrui333 chenrui333 deleted the rustfmt-1.7.0 branch April 28, 2024 12:52
@github-actions github-actions bot added the outdated PR was locked due to age label May 29, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autobump CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age ready to merge PR can be merged once CI is green rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants