Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gollum: deprecate #178661

Merged
merged 1 commit into from
Jul 27, 2024
Merged

gollum: deprecate #178661

merged 1 commit into from
Jul 27, 2024

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Jul 27, 2024 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@chenrui333
gollum: deprecate
e859ee1 
Signed-off-by: Rui Chen <[email protected]>
@chenrui333 chenrui333 requested a review from stefanb July 27, 2024 12:56
@github-actions github-actions bot added go Go use is a significant feature of the PR or issue formula deprecated Formula deprecated labels Jul 27, 2024
@github-actions GitHub Actions

This comment was marked as resolved.

Sign in to view
@chenrui333 chenrui333 added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Jul 27, 2024
@chenrui333 chenrui333 enabled auto-merge July 27, 2024 13:26
@chenrui333 chenrui333 added this pull request to the merge queue Jul 27, 2024
Merged via the queue into master with commit b1e3c5b Jul 27, 2024
17 of 24 checks passed
@chenrui333 chenrui333 deleted the gollum-deprecate branch July 27, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanb stefanb stefanb approved these changes

Assignees
No one assigned
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. formula deprecated Formula deprecated go Go use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenrui333 @stefanb