Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dolt 1.43.12 #196779

Merged
merged 2 commits into from
Nov 6, 2024
Merged

dolt 1.43.12 #196779

merged 2 commits into from
Nov 6, 2024

Conversation

BrewTestBot
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

release notes
# Merged PRs

dolt

  • 8526: Avoid comparing sql.Types in dolt diff
    Fixes Panic on dolt show dolthub/dolt#8511
    Not all implementations of sql.Type are comparable. In particular, the enum type has a map field which makes the entire type incomparable.
    To avoid doing this comparison in the chooseMostFlexibleType function, we modify it to compare the underlying type tag instead. This PR also short-circuits computing a unified schema unless the schema has changed.
  • 8514: Better view caching
    Binding a table name to a catalog symbol previously always loaded the schemas table from disk to first attempt binding a view. Now we cache dolt_schemas using its hash. If the table does not exist, no views are defined, and we short circuit attempting to bind a name to a view.

go-mysql-server

  • 2733: disabling read-comitted
  • 2732: Get field string concat
    Replace fmt.Sprintf with string concat (+).
    BenchmarkSprintf-12        	18748582	        63.29 ns/op
    BenchmarkAddString-12    	39934550	        27.61 ns/op
    
  • 2729: move applyEventScheduler logic and eventscheduler to builder
  • 2712: Planbuilder Authorization
    • Embedded Authorization dolthub/vitess#372
      What's missing:
    • SHOW commands aren't in yet
    • information_schema doesn't restrict it's output yet
    • Need far more robust testing than what currently exists
      I think SHOW and information_schema will probably have the same solution, which may be to continue doing what we were doing before. Besides that, pretty much every works according to our current tests (outside of the aforementioned missing items).

vitess

Closed Issues

  • 8511: Panic on dolt show

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Nov 6, 2024
Copy link
Contributor

github-actions bot commented Nov 6, 2024

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Nov 6, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 6, 2024
Merged via the queue into master with commit 7c15e56 Nov 6, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the bump-dolt-1.43.12 branch November 6, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants