Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bump
Created with
brew bump-formula-pr
.release notes
sql.Types
indolt diff
Fixes Panic on
dolt show
dolthub/dolt#8511Not all implementations of
sql.Type
are comparable. In particular, the enum type has a map field which makes the entire type incomparable.To avoid doing this comparison in the
chooseMostFlexibleType
function, we modify it to compare the underlying type tag instead. This PR also short-circuits computing a unified schema unless the schema has changed.Binding a table name to a catalog symbol previously always loaded the schemas table from disk to first attempt binding a view. Now we cache
dolt_schemas
using its hash. If the table does not exist, no views are defined, and we short circuit attempting to bind a name to a view.go-mysql-server
Replace
fmt.Sprintf
with string concat (+).applyEventScheduler
logic andeventscheduler
to builderWhat's missing:
information_schema
doesn't restrict it's output yetI think
SHOW
andinformation_schema
will probably have the same solution, which may be to continue doing what we were doing before. Besides that, pretty much every works according to our current tests (outside of the aforementioned missing items).vitess
…d, which doesn't work with custom formatters)
Closed Issues
dolt show