Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/triage: dotnet no longer needs self-hosted Linux #197938

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Nov 16, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

After rewriting .NET formula to use tarball (#196479), the disk space needed is now within standard Linux runner.

In Homebrew, git checkout not only needs extra space for repo, but also has to duplicate the git repo due to how unpack strategy is handled.

This was temporarily changed by switching to hardlinks, but I had replaced it again as cp -l is relatively new on macOS and has some bug reports. Also, the new mv approach is faster for main use case (bottle pour)

We could consider allowing cp -l on Linux as feature should be more stable and well tested in GNU coreutils. Only would need to look into brew features like --keep-tmp (not a common use case) behaves as these may still be hardlinked and change on subsequent brew installs

@cho-m cho-m requested a review from a team as a code owner November 16, 2024 19:28
@github-actions github-actions bot added workflows PR modifies GitHub Actions workflow files automerge-skip `brew pr-automerge` will skip this pull request labels Nov 16, 2024
@cho-m cho-m added this pull request to the merge queue Nov 17, 2024
Merged via the queue into master with commit bdbd25b Nov 17, 2024
20 checks passed
@cho-m cho-m deleted the dotnet-remove-self-hosted branch November 17, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request workflows PR modifies GitHub Actions workflow files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants