Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-okta 0.19.5 #36600

Closed
wants to merge 1 commit into from
Closed

aws-okta 0.19.5 #36600

wants to merge 1 commit into from

Conversation

logikal
Copy link
Contributor

@logikal logikal commented Jan 31, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

  • Added dependency on govendor for building
  • Fixed tests
 > brew install --build-from-source aws-okta
==> Downloading https://github.com/segmentio/aws-okta/archive/v0.19.5.tar.
Already downloaded: /Users/seankilgore/Library/Caches/Homebrew/downloads/37b6dfaf1ee1aac9ac9094c8f98cca1e2636aa5e595f773b07fb608c69c08483--aws-okta-0.19.5.tar.gz
==> govendor sync
==> go build -ldflags -X main.Version=0.19.5
🍺  /usr/local/Cellar/aws-okta/0.19.5: 5 files, 14MB, built in 19 seconds
 >  brew test aws-okta
Testing aws-okta
 > $ brew audit --strict aws-okta
 > $

@lembacon
Copy link
Member

lembacon commented Feb 1, 2019

Thanks @logikal!

@lock lock bot added the outdated PR was locked due to age label Mar 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants