Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mapnik 3.0.23 #52638

Closed
wants to merge 1 commit into from
Closed

mapnik 3.0.23 #52638

wants to merge 1 commit into from

Conversation

pOmelchenko
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@pOmelchenko
Copy link
Contributor Author

Tested with deps from master and tested with update icu4c (from #52481) too. In all tries I have success compiling

@pOmelchenko
Copy link
Contributor Author

@Bo98 if I add changes with reverting deleted rows about bottles, queue will update? Or I will have two tries into queue?

@Bo98
Copy link
Member

Bo98 commented Apr 6, 2020

On Jenkins it replaces your original build. On GitHub Actions it will have two entries but don't worry about that - I can easily cancel one.

Go ahead and revert the bottle lines.

@pOmelchenko
Copy link
Contributor Author

Please check changes in that PR before jobs start :) Because I'm not sure in last times with changes in this repo 🙈

@Bo98
Copy link
Member

Bo98 commented Apr 6, 2020

Looks good. We prefer the commit message to be "mapnik 3.0.23" rather than "update mapnik version" but I can probably correct that while merging since it's just one commit.

@pOmelchenko
Copy link
Contributor Author

Thx! In other PR I fix all commit messages with all recommendations

@Bo98 Bo98 closed this in 0b5a801 Apr 7, 2020
@pOmelchenko pOmelchenko deleted the mapnik-3.0.23 branch April 7, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants