Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node 6.7.0 #5312

Closed
wants to merge 1 commit into from
Closed

node 6.7.0 #5312

wants to merge 1 commit into from

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Sep 28, 2016

Created with brew bump-formula-pr.

@dunn
Copy link
Contributor

dunn commented Sep 28, 2016

Does npm need to be bumped?

@DomT4 DomT4 closed this in bd05ec3 Sep 28, 2016
@DomT4
Copy link
Member

DomT4 commented Sep 28, 2016

Nope. We bumped it too hard quite considerably last time, so upstream are going to be playing catchup for a while, heh.

Merged in bd05ec3. Thank you for another contribution to Homebrew @JLHwung! 😺.

@JLHwung JLHwung deleted the node-6.7.0 branch September 28, 2016 04:27
@JLHwung
Copy link
Contributor Author

JLHwung commented Sep 28, 2016

@DomT4 What's the policy of bumping npm version of node? Here is the comments from the source

# We track major/minor from upstream Node releases.
# We will accept *important* npm patch releases when necessary.

I would like to make sure if this is the bumping policy.

AFAIK node 6.7.0 does not bundle npm 3.10.7. So, is 3.10.7 an important patch releases or just a situation where it is bumped accidentally?

@DomT4
Copy link
Member

DomT4 commented Sep 28, 2016

We track what Node bundles upstream, unless what Node bundles upstream has security or major usability problems resolved in a newer release. Our last bump was just too heavy on the npm update, but no point reverting, will just try to avoid further npm updates till upstream catches us up.

Sent from my iPhone

On 28 Sep 2016, at 05:32, Junliang Huang [email protected] wrote:

@DomT4 What's the policy of bumping npm version of node? Here is the comments from the source

We track major/minor from upstream Node releases.

We will accept important npm patch releases when necessary.

I would like to make sure if this is the bumping policy.

AFAIK node 6.7.0 does not bundle npm 3.10.7. So, is 3.10.7 an important patch releases or just a situation where it is bumped accidentally?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@JLHwung
Copy link
Contributor Author

JLHwung commented Sep 28, 2016

@DomT4 Crystal clear for the policy.

If last bump is just too heavy, how about rolling back to 3.10.3 and align with the upstream? Or do it last time when version is bumped without any npm updates.

@DomT4
Copy link
Member

DomT4 commented Sep 28, 2016

Nobody's reported any problems so let's leave it where it is and just try to remember in future to keep it as in sync as possible.

@mech
Copy link

mech commented Oct 5, 2016

Encounter the strange:

(node:4558) Warning: Possible EventEmitter memory leak detected. 11 error listeners added. Use emitter.setMaxListeners() to increase limit

with NPM -v3.10.7, reportedly fixed on -v3.10.8

Just annoying warnings, but NPM appear still working.

@JLHwung JLHwung mentioned this pull request Nov 23, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants