Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tarantool 2.3.2.1 #53478

Closed

Conversation

avtikhon
Copy link
Contributor

@avtikhon avtikhon commented Apr 21, 2020

Set stable release to 2.3.2.1 version.

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@bayandin
Copy link
Member

bayandin commented Apr 21, 2020

Could you please change commit message to tarantool 2.3.2.1

And there're some references to Homebrew shims directory which don't work outside of Homebrew's superenv:

==> brew audit --skip-style tarantool --online
Error: 1 problem in 1 formula detected
tarantool:
  * Files were found with references to the Homebrew shims directory.
    The offending files are:
      bin/tarantool
      include/tarantool/module.h
==> FAILED

For include/tarantool/module.h it's this line:

#define COMPILER_INFO "@@HOMEBREW_REPOSITORY@@/Library/Homebrew/shims/mac/super/clang @@HOMEBREW_REPOSITORY@@/Library/Homebrew/shims/mac/super/clang++"

@bayandin bayandin added audit failure CI fails while auditing the software and removed audit failure CI fails while auditing the software labels Apr 21, 2020
@Bo98
Copy link
Member

Bo98 commented Apr 22, 2020

Bypassing a significant portion of the superenv during the actual build kinda sucks. Would modifying COMPILER_INFO be any better?

(We should also wait until icu4c 66.1 build is complete)

@bayandin
Copy link
Member

bayandin commented Apr 22, 2020

Bypassing a significant portion of the superenv during the actual build kinda sucks. Would modifying COMPILER_INFO be any better?

It seems the only way to do it is to patch ./src/trivia/config.h.cmake, will it be ok?

- #define COMPILER_INFO "@CMAKE_C_COMPILER@ @CMAKE_CXX_COMPILER@"
+ #define COMPILER_INFO "/usr/bin/clang /usr/bin/clang++"

(We should also wait until icu4c 66.1 build is complete)

Ok, will merge after #52481

@bayandin bayandin changed the title Update Tarantool main release tarantool 2.3.2.1 Apr 22, 2020
@bayandin bayandin self-assigned this Apr 22, 2020
@Bo98
Copy link
Member

Bo98 commented Apr 22, 2020

will it be ok?

I think so. It's effectively the same as how it replaces those things in the build script anyway. Better than avoiding the superenv IMO.

@bayandin bayandin mentioned this pull request Apr 23, 2020
5 tasks
Co-Authored-By: Alexander Bayandin <[email protected]>
@bayandin bayandin force-pushed the avtikhon/update-stable-release branch from 4e78c41 to 0f0fffd Compare April 23, 2020 15:04
@BrewTestBot
Copy link
Member

@bayandin has triggered a merge.

@bayandin
Copy link
Member

Thanks @avtikhon!

@bayandin bayandin removed their assignment Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants