monero: build bottle #53562
Closed
monero: build bottle #53562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By any chance do you know was there attempts to upstream that patch? |
|
I tried looking for that, but didn't find anything. It is effectively a revert of monero-project/monero@6b85398 which was done because they needed patched version of miniupnpc for https://hackerone.com/reports/340012. However miniupnpc has those patches incorporated into 2.1, which Homebrew ships. There's now no real difference between bundled and system miniupnpc: https://github.com/monero-project/miniupnp/compare/monero Upstream have previously shown little interest in fixing the conflict with miniupnpc (they say they don't support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bottle did not get generated in #52481.
(This commit will not be merged)