python@*: fix post_install linkages and tweak caveats #57655
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lembacon
commented
Jul 8, 2020
| @@ -223,11 +224,6 @@ def post_install | |||
| (libexec/"bin").install_symlink (bin/versioned_name).realpath => unversioned_name | |||
| end | |||
|
|
|||
| # post_install happens after link | |||
There was a problem hiding this comment.
[email protected] will no longer be linked into the prefix, so this should be removed.
There was a problem hiding this comment.
Good point - I'll update my pull request to reflect this.
lembacon
commented
Jul 8, 2020
|
|
||
| Unversioned symlinks `python`, `python-config`, `pip` etc. pointing to | ||
| `python3`, `python3-config`, `pip3` etc., respectively, have been installed into | ||
| #{opt_libexec}/bin | ||
|
|
||
| You can install Python packages with | ||
| pip3 install <package> | ||
| #{opt_bin}/pip3 install <package> | ||
| They will install into the site-package directory | ||
| #{HOMEBREW_PREFIX/"lib/python#{xy}/site-packages"} |
There was a problem hiding this comment.
This is still true.
|
Oops, a little bit slow. #57654 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?[email protected]is now versioned keg-only, while[email protected]now becomes the default python3 and is being linked into the prefix. Inpost_install, linkages ofpip3andwheel3should be updated. And caveats also need some minor tweaks.Fixes #57651.