Create thread pool that blocks when full #2186
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, the theory here, is that it will be much better to just block the producing thread (main rxjava thread carrying mesos events) when the status update queue is full than to throw a RejectedExecutionException and abort/restart/bai//etc. If we are falling behind on status updates it's nearly always the case that those have to catch up first before we can do anything else.
Java-y bits added here are a custom ThreadPoolQueue which, because it delegates to put, will block on the put to the underlying queue when full instead of throwing the reject exception