Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread and stream clean up #2188

Merged
merged 1 commit into from
Mar 19, 2021
Merged

Thread and stream clean up #2188

merged 1 commit into from
Mar 19, 2021

Conversation

ssalinas
Copy link
Member

  • Don't start all the threads at once on sized pools (non-scheduler instances were sitting with hundreds of them open and unused)
  • Clean up open streams on failed download calls. It looked like we possibly had a leak previously, keeping these open. Unclear if that was the case or not and need to test

@ssalinas ssalinas added the staging Merged to staging branch label Mar 17, 2021
@rosalind210
Copy link
Contributor

🚢

@ssalinas ssalinas merged commit 136686c into master Mar 19, 2021
@ssalinas ssalinas deleted the fewer_threads branch March 19, 2021 13:19
@ssalinas ssalinas added this to the 1.5.0 milestone May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staging Merged to staging branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants