Smarter timeouts in offer loop #2224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WH-77
reviewed
Aug 12, 2021
| // Decisions about resources to use, specifically ports are made during the buildTask call, however | ||
| // these resources aren't subtracted from the offer until the addMatchedTask call, making this method | ||
| // not thread safe | ||
| private synchronized void acceptTask( |
There was a problem hiding this comment.
Would it be possible/preferable to synchronize on the offerHolder instead of the method, to avoid blocking acceptTask calls that are using different offers?
| startRequest > | ||
| mesosConfiguration.getOfferLoopRequestTimeoutMillis() && | ||
| evaluated > 1 | ||
| ) |
There was a problem hiding this comment.
nit - would be more readable with variables for each condition
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stop if the total time is too long or the time processing a single request is too long