Cleanup old decommissioned agents #2253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know that this is actually safe. I think we also need the condition that we have not received offers from it in that amount of time as well. Currently, if an agent is still active with the mesos master, but decommissioned for us, we are continually receiving offers. So, if we were to delete it from our agents list -> get a new offer, we will actually end up adding it back as active. There is a maintenance mode in mesos master (old issue #948) that we could integrate with to stop offers coming in when decomissioned |
ssalinas
approved these changes
Jan 18, 2022
… still in mesos master
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming that if an agent is decommissioned (not stuck decommissioning) on startup and there aren't resources associated with it in the mesos master, it should be safe to clean it up the same way as dead/missing agents.
cc - @ssalinas