Retry failed tasks with new deploys #2269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we wire through a unit test for this one? Curious if the pending task will 1) come all the way through and 2) have the old or the new deploy attached to it and 3) if the old/inactive deploy, will it actually launch the task correctly? |
WH77
commented
Feb 22, 2022
| scheduler.drainPendingQueue(); | ||
| resourceOffers(); | ||
|
|
||
| // TODO - new deploys have new deploy statistics, so we lose track of the # of retries |
There was a problem hiding this comment.
Tasks could exceed numRetries if they deploy often enough, but cooldowns should keep the retries from becoming a problem.
Debated adding a new retryIgnoreDeploy field to requests or deploys, but figured that was overkill.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix failed tasks not being retried due to newer deploys while the tasks were running.
The branch that skips the newer deploy short circuit should generally get to the current retry logic, but all the other checks / cooldowns still apply.
The log level changes are in case I was mistaken and that the real cause of these tasks not getting retried was obsolete requests all along.
cc - @ssalinas , @pschoenfelder