Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various bug fixes and stability improvements #2281

Merged
merged 10 commits into from
Apr 6, 2022
Merged

Conversation

ssalinas
Copy link
Member

@ssalinas ssalinas commented Apr 5, 2022

  • An LB delete that gets back Invalid request... will never be able to complete. Junk it and move on
  • Clean up a number of deprecated things in CuratorAsyncManager and prefer more lambdas over old style
  • In the load balanced curator, attempt to use the same curator client for the same thread where possible to avoid race conditions hitting possibly different zk instances
  • For tasks that do not have any active task data when they hit status updates, clean them up. These will only cause issues if allowed to persist (and will never actually be added to LB)
  • Fix a possible overflow in length for task usage column with task ids oover 200 chars. This fails gracefully and is fine to leave empty
  • Rerun the scheduler check after marking as started during startup. this should fix a case where a status update came in but we did not schedule a new pending task for it yet because we were not marked as started

@ssalinas ssalinas added the staging Merged to staging branch label Apr 6, 2022
@pschoenfelder
Copy link
Contributor

🚢

@ssalinas ssalinas merged commit 9b0cc5c into master Apr 6, 2022
@ssalinas ssalinas deleted the deploy_bug_fixes branch April 6, 2022 18:23
@ssalinas ssalinas added this to the 1.5.0 milestone May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staging Merged to staging branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants