-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add-ons support #6468
base: master
Are you sure you want to change the base?
Add-ons support #6468
Conversation
b2d9ae7
to
5ee0ba8
Compare
@keianhzo hello, may i know is addon ready to use in production please? |
@dirkarnez It is my opinion that the add-ons branch/PR is not yet ready for production use. A list of the current issues can be found in this Discord comment: https://discord.com/channels/498741086295031808/535606666708910101/1255627984400941236
|
@Exairnous Thank you and i see, may i know how to play with addon as experimenting? Is this branch ("addon") dependent on other hubs' repos? Thanks! |
@dirkarnez If you already have a Hubs Community Edition instance set up, you can rebuild the Hubs client with the addons branch and deploy it[1]. Otherwise, you'll need to work with Hubs-Compose[2]. For both, make sure to do an npm ci after switching to the addons branch to update the node modules and get the actual add-ons to play with. After running bin/init for Hubs Compose, you'll need to go into the hubs client folder it clones and switch the branch to the addons branch. There have been some issues reported about getting the add-ons to work, so if you run into trouble your best bet is probably to ask in the Hubs Discord server. I hope this helps. Good luck! [1] https://github.com/Hubs-Foundation/hubs-blender-files/blob/main/creator-labs-files/CL-archive/ghost-to-md-output/2023-10-16-community-edition-case-study-quick-start-on-gcp-w-aws-services.md#deploy-custom-apps |
@Exairnous OMG, thank you so much for your very detailed information that helps a lot! |
@dirkarnez You're welcome! :) |
Update the links in the various package.json and package-lock.json files to point to the new Hubs Foundation URLs. This also helps fix conflicts when fetching add-ons and their dependencies.
This returns to getting the latest versions of the addons and also helps fix conflicts when fetching add-ons and their dependencies.
npm throws errors if the capitalization between a dependency listed here and a dependency listed in an addon is different, so this makes sure there are no dependency conflicts.
Merge in the revert of the scene grabbables support PR. This likely breaks the addons branch because this functionality is depended on by at least the behavior graphs addon and possibly addons themselves.
Note: since the scene grabbables PR was reverted in the master branch, this PR now additionally adds support for scene grabbables. |
This PR adds support for Add-ons in Hubs. For some background, see here: #6099
You can find the Hubs TS typings here (WIP): https://github.com/MozillaReality/hubs-ts-types
A template to simplify add-on development: https://github.com/MozillaReality/hubs-template-addon
There are also a couple demo add-on:
Duck add-on. This was previously part of the client code but in this branch has been converted to an add-on: https://github.com/MozillaReality/hubs-duck-addon
Portals add-on. A simple portals implementation as an add-on to illustrate a more complex Hubs add-on:
https://github.com/MozillaReality/hubs-portals-addon
To add add-ons to a client:
addons.json
file.