Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display OSS sponsors #1644

Merged
merged 5 commits into from
Dec 3, 2024
Merged

Display OSS sponsors #1644

merged 5 commits into from
Dec 3, 2024

Conversation

HugoGresse
Copy link
Owner

@HugoGresse HugoGresse commented Nov 12, 2024 •
edited
Loading

  • display open source sponsor on OpenFeedback
  • Feedback app
  • Admin app
  • Vitrine app
    image
    image
    image

@HugoGresse HugoGresse changed the title Add sponsor to feedback footer Display OSS sponsors Nov 12, 2024
hound[bot]
hound bot reviewed Nov 12, 2024
View reviewed changes
src/env.ts Show resolved Hide resolved
@HugoGresse HugoGresse self-assigned this Nov 12, 2024
@HugoGresse HugoGresse added admin app Admin app (openfeedback.io/admin) feedback app Feedback related issue labels Nov 12, 2024
@cypress Cypress
Copy link

cypress bot commented Nov 12, 2024 •
edited
Loading

open-feedback    Run #2951

Run Properties:  status check passed Passed #2951  •  git commit 27746e7c15: Display OSS sponsors (#1644)
Project open-feedback
Branch Review main
Run status status check passed Passed #2951
Run duration 02m 11s
Commit git commit 27746e7c15: Display OSS sponsors (#1644)
Committer Hugo Gresse
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 14
View all changes introduced in this branch ↗︎

@HugoGresse HugoGresse requested a review from Copilot November 16, 2024 14:20
Copilot
Copilot AI reviewed Nov 16, 2024
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 9 changed files in this pull request and generated 3 suggestions.

Files not reviewed (4)
  • .env: Language not supported
  • src/root/translations/languages/en.root.json: Language not supported
  • src/root/translations/languages/fr.root.json: Language not supported
  • src/root/HowItWorks.jsx: Evaluated as low risk
Comments skipped due to low confidence (1)

src/feedback/layout/Footer.jsx:58

  • The string 'Devenir sponsor' is hardcoded and should use the translation function t for localization.
Devenir sponsor

src/root/Sponsor.jsx Outdated Show resolved Hide resolved
src/baseComponents/useOSSSponsors.ts Outdated Show resolved Hide resolved
src/env.ts Show resolved Hide resolved
@HugoGresse HugoGresse marked this pull request as ready for review November 23, 2024 15:29
@HugoGresse HugoGresse merged commit 27746e7 into main Dec 3, 2024
9 checks passed
@HugoGresse HugoGresse deleted the sponsors-footer branch December 3, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

@hound hound[bot] hound[bot] left review comments

Assignees

@HugoGresse HugoGresse

Labels
admin app Admin app (openfeedback.io/admin) feedback app Feedback related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@HugoGresse