Make ubus call poe sendframe a little more user-friendy
#40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrnuke
force-pushed
the
mrnuke-senframe-send-it
branch
from
387fec6 to
45ffe35
Compare
The sendframe command intermittently fails with an error message,
despite the command being successfully sent and acknowledged by the
PoE controller:
"Command failed: Parsing message data failed"
mcu_queue_cmd() returns the number of bytes written, or a negative
error code. Whith an active command queue, the frame is queued up
instead being sent right away. The return code is 0, which corresponds
to UBUS_STATUS_OK. No error.
However, when the queue is empty, the frame is sent right away, with
a return code of 12. While this still means success, it also means
UBUS_STATUS_PARSE_ERROR.
Since realtek-poe operates in the linux error code space, not
UBUS_STATUS_* space, the error codes are not interchangeable. So go
ahead and properly translate the return to the correct ubus code.
Lesson learned: don't mix your error codes. It's not a good recipe.
Signed-off-by: Alexandru Gagniuc <[email protected]>
The broadcom dialect has commands for firmware update and recovery. It can also erase the device firmware. This makes exposing raw frames via the "sendframe" command potentially dangerous. To reduce the risk of causing damage, only enable the "sendframe" command when debug mode, `-d`, is enabled. Signed-off-by: Alexandru Gagniuc <[email protected]>
mrnuke
force-pushed
the
mrnuke-senframe-send-it
branch
from
45ffe35 to
fa3ca0a
Compare
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.