Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cave biome over surface on eroded surface. #23

Closed
HydrolienF opened this issue Jan 15, 2025 · 0 comments
Closed

Cave biome over surface on eroded surface. #23

HydrolienF opened this issue Jan 15, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@HydrolienF
Copy link
Owner

Deep dark can be found on surface when the surface is eroded. This is probably because surface level is checked once only for each 444 biome area.

It can be fix in CustomBiomeSource.topYOfSurfaceWorld(...) by reading all x & z possible values for that 444 biome area.

We could make it configurable to check 1 value only, the 4 corners or all 16 values.
@HydrolienF HydrolienF added the bug Something isn't working label Jan 15, 2025
HydrolienF added a commit that referenced this issue Jan 15, 2025
@HydrolienF
Fix cave biome that where over surface on eroded biome. #23
d0fe416 
It's done by checking each surface min y level for the 4*4 area of the biome.
(Haven't been tested yet.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@HydrolienF