-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new categories and uses to the Default Taxonomy #144
Conversation
@NevilleS I'm thinking this needs a 2.0 bump? These are pretty large changes, and will definitely break things as we don't have proper versioning in yet |
I'm investigating CI failures here due to our friend |
@pattisdr will merging this hinder your in-flight work in any way? |
Not sure, you seem to be working in different files though. Either way we both have items that need to get in this sprint so I'd just go for it when you're ready - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ThomasLaPiana Large effort here!
Reviewed by comparing taxonomy files to this confluence doc. I understand there have been other conversations since this doc and it is outdated in places so I'll leave the details for you to sort -
Nice testing additions as well. Another nice test to add might be one to make sure all the parents (and their parents, etc) exist.
@pattisdr the review here is kind of confusing... I was given a CSV file and told that it is the intended end-state of the taxonomy (one CSV for each type actually, categories and uses) I converted those CSV files into google sheets and marked them up/had comments as per the linked sheets at the top of the PR Anything that isn't in that file, I took as an explicit flag to remove it from the current taxonomy. There was additional discussion in the comments around what to do with certain fields Hugely appreciate the thorough review here! I know it's hard to follow, I want @rsilvery to chime in as well and confirm the CSV in this PR matches the requirements. This is very detail-oriented work and deserves a lot of eyes on to verify my changes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your changes here - approved with the addition of the missing parent fides key item
Is there still something I need to review here? I don't get GH notifications in a timely way so please ping me on Slack if so. |
Closes #142
Closes #141
Description Of Changes
Link to Data Categories Sheet
Link to Data Uses Sheet
Follow-Up Issue for Docs: https://github.com/ethyca/fideslang/issues/150
NOTE: CI fixes happening here: https://github.com/ethyca/fideslang/pull/145
All of the changes we make here will need to get listed out for the corresponding migration PR over in
Fides
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md