Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PyYAML Checks #145

Merged
merged 5 commits into from
Aug 9, 2023
+19 −0
Merged

Fix PyYAML Checks #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fb3c0cb
Fix PyYAML Checks
ThomasLaPiana Aug 9, 2023
a0b9538
fix: test another fix
ThomasLaPiana Aug 9, 2023
24da4de
fix: add the Cython pin to the static checks
ThomasLaPiana Aug 9, 2023
eb42981
fix: add the fix to the tests
ThomasLaPiana Aug 9, 2023
2af0953
docs: changelog
ThomasLaPiana Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/workflows/pr_checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,12 @@ jobs:
python-version: "3.10.11"
cache: "pip"

- name: Pin Cython
run: |
echo 'Cython < 3.0' > /tmp/constraint.txt
PIP_CONSTRAINT=/tmp/constraint.txt pip wheel PyYAML==5.4.1
pip install 'PyYAML==5.4.1'

- name: Install Package
run: pip install .

Expand All @@ -72,6 +78,12 @@ jobs:
python-version: ${{ env.DEFAULT_PYTHON_VERSION }}
cache: "pip"

- name: Pin Cython
run: |
echo 'Cython < 3.0' > /tmp/constraint.txt
PIP_CONSTRAINT=/tmp/constraint.txt pip wheel PyYAML==5.4.1
pip install 'PyYAML==5.4.1'

- name: Install Nox
run: pip install nox

Expand All @@ -96,6 +108,12 @@ jobs:
python-version: ${{ matrix.python_version }}
cache: "pip"

- name: Pin Cython
run: |
echo 'Cython < 3.0' > /tmp/constraint.txt
ThomasLaPiana marked this conversation as resolved.
Show resolved Hide resolved
PIP_CONSTRAINT=/tmp/constraint.txt pip wheel PyYAML==5.4.1
pip install 'PyYAML==5.4.1'

- name: Install Nox
run: pip install nox

Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ The types of changes are:
### Fixed

- Don't allow duplicate entries for DatasetCollections as part of Datasets [#136](https://github.com/ethyca/fideslang/pull/136)
- Cython/PyYAML versions breaking builds [#145](https://github.com/ethyca/fideslang/pull/145)

## [1.4.3](https://github.com/ethyca/fideslang/compare/1.4.2...1.4.3)

Expand Down