Merge pull request #2205 from Stephan14/fix_metrics_leak

fix: prevent metrics leak when authenticate fails

broker.go

@@ -33,7 +33,7 @@ type Broker struct {
 	responses     chan *responsePromise
 	done          chan bool
 
-	registeredMetrics []string
+	registeredMetrics map[string]struct{}
 
 	incomingByteRate       metrics.Meter
 	requestRate            metrics.Meter
@@ -1723,27 +1723,36 @@ func (b *Broker) registerMetrics() {
 }
 
 func (b *Broker) unregisterMetrics() {
-	for _, name := range b.registeredMetrics {
+	for name := range b.registeredMetrics {
 		b.conf.MetricRegistry.Unregister(name)
 	}
 	b.registeredMetrics = nil
 }
 
 func (b *Broker) registerMeter(name string) metrics.Meter {
 	nameForBroker := getMetricNameForBroker(name, b)
-	b.registeredMetrics = append(b.registeredMetrics, nameForBroker)
+	if b.registeredMetrics == nil {
+		b.registeredMetrics = map[string]struct{}{}
+	}
+	b.registeredMetrics[nameForBroker] = struct{}{}
 	return metrics.GetOrRegisterMeter(nameForBroker, b.conf.MetricRegistry)
 }
 
 func (b *Broker) registerHistogram(name string) metrics.Histogram {
 	nameForBroker := getMetricNameForBroker(name, b)
-	b.registeredMetrics = append(b.registeredMetrics, nameForBroker)
+	if b.registeredMetrics == nil {
+		b.registeredMetrics = map[string]struct{}{}
+	}
+	b.registeredMetrics[nameForBroker] = struct{}{}
 	return getOrRegisterHistogram(nameForBroker, b.conf.MetricRegistry)
 }
 
 func (b *Broker) registerCounter(name string) metrics.Counter {
 	nameForBroker := getMetricNameForBroker(name, b)
-	b.registeredMetrics = append(b.registeredMetrics, nameForBroker)
+	if b.registeredMetrics == nil {
+		b.registeredMetrics = map[string]struct{}{}
+	}
+	b.registeredMetrics[nameForBroker] = struct{}{}
 	return metrics.GetOrRegisterCounter(nameForBroker, b.conf.MetricRegistry)
 }