Skip to content

Commit

Permalink
Merge pull request #794 from Shopify/tweak-docs
Browse files Browse the repository at this point in the history
Tweak some docs
  • Loading branch information
eapache authored Dec 20, 2016
2 parents bb18641 + 8d739a4 commit e4c4741
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
4 changes: 2 additions & 2 deletions consumer.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ type Consumer interface {
// or OffsetOldest
ConsumePartition(topic string, partition int32, offset int64) (PartitionConsumer, error)

// HighWaterMarks returns the current high water marks for each topic and partition
// Consistency between partitions is not garanteed since high water marks are updated separately.
// HighWaterMarks returns the current high water marks for each topic and partition.
// Consistency between partitions is not guaranteed since high water marks are updated separately.
HighWaterMarks() map[string]map[int32]int64

// Close shuts down the consumer. It must be called after all child
Expand Down
4 changes: 3 additions & 1 deletion produce_request.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ const (
NoResponse RequiredAcks = 0
// WaitForLocal waits for only the local commit to succeed before responding.
WaitForLocal RequiredAcks = 1
// WaitForAll waits for all replicas to commit before responding.
// WaitForAll waits for all in-sync replicas to commit before responding.
// The minimum number of in-sync replicas is configured on the broker via
// the `min.insync.replicas` configuration key.
WaitForAll RequiredAcks = -1
)

Expand Down

0 comments on commit e4c4741

Please sign in to comment.